BREAKING Add component wrapper helper to the search component #4540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshGDS
changed the title
AshGDS
changed the title
AshGDS
force-pushed
the
search-component-wrapper
branch
from
309aeb0 to
5adedb3
Compare
AshGDS
force-pushed
the
search-component-wrapper
branch
from
5adedb3 to
af1151c
Compare
andysellick
approved these changes
Jan 13, 2025
| if local_assigns[:on_govuk_blue].eql?(true) | ||
| classes << "gem-c-search--on-govuk-blue" | ||
| component_helper.add_class("gem-c-search--on-govuk-blue") |
There was a problem hiding this comment.
Non-blocking: you could probably rewrite this bit as follows, but it might be clearer as-is. I'll leave it to you.
component_helper.add_class("gem-c-search--on-govuk-blue") if local_assigns[:on_govuk_blue].eql?(true)
component_helper.add_class("gem-c-search--on-white") unless local_assigns[:on_govuk_blue].eql?(true)
| end | ||
| classes << "gem-c-search--separate-label" if local_assigns.include?(:inline_label) or local_assigns.include?(:label_size) | ||
| component_helper.add_class("gem-c-search--separate-label") if local_assigns.include?(:inline_label) or local_assigns.include?(:label_size) |
There was a problem hiding this comment.
Nitpick: I'd move this line up to join the rest of the add_class lines, above.
spec/components/search_spec.rb
Outdated
| @@ -100,7 +100,7 @@ def component_name | |||
| it "applies data attributes when provided" do | |||
| render_component( | |||
| button_text: "Some test text", | |||
| data_attributes: { | |||
| button_data_attributes: { | |||
There was a problem hiding this comment.
If you're certain that these button attributes aren't set anywhere, I think it'd be a good opportunity to remove this option. I'd double check it's not being picked up in any JS anywhere.
AshGDS
force-pushed
the
search-component-wrapper
branch
from
af1151c to
83fbd94
Compare
AshGDS
force-pushed
the
search-component-wrapper
branch
from
83fbd94 to
0a2dd94
Compare
Breaking as it: - Renames the `id` option to `label_id` - Renames `data_attributes` to `button_data_attributes`
AshGDS
force-pushed
the
search-component-wrapper
branch
from
0a2dd94 to
fa5ccd3
Compare
This was referenced Jan 13, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
searchcomponent.idoption tolabel_iddata_attributestobutton_data_attributes- though this is not used anywhere on GOV.UK (should it removed? I think it was needed for when Universal Analytics was on GOV.UK.)Why
As the trello card states:
Visual changes
A new example has been added.