BREAKING Use component wrapper on modal dialogue component #4555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshGDS
force-pushed
the
modal-component-wrapper
branch
from
ba7a45d to
ce609a7
Compare
AshGDS
force-pushed
the
modal-component-wrapper
branch
from
ce609a7 to
d9a8b7e
Compare
andysellick
approved these changes
Jan 15, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This is a breaking change, as it removes the data_attributes hash which was placed on a child element. data_attributes is not actually used across any templates currently, so it can be safely removed.
This should only affect two templates which I verified using [this search criteria](https://github.com/search?q=org%3Aalphagov+govuk_publishing_components%2Fcomponents%2Fbig_number+AND+data_attributes&type=code
Why
As the trello card states:
Visual changes
Removed an example.