PP-7843 Stop selecting default option on permission level radios #4148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbishop1
requested changes
Oct 19, 2023
| @@ -60,7 +60,9 @@ async function invite (req, res, next) { | |||
| lodash.set(req, 'session.pageData', { invitee }) | |||
| res.redirect(303, formatServicePathsFor(paths.service.teamMembers.invite, externalServiceId)) | |||
| } else if (!role) { | |||
| next(new Error(`Cannot identify role from user input ${roleId}`)) | |||
| req.flash('genericError', 'Select the team member\'s permission level') | |||
There was a problem hiding this comment.
If you use a right single quotation mark (that is, ’ instead of ') then it looks nicer and does not need to be escaped.
There was a problem hiding this comment.
Gotcha! Have updated this as above.
package-lock.json
Outdated
| @@ -64,7 +64,7 @@ | |||
| "chai-arrays": "2.2.0", | |||
| "chai-as-promised": "7.1.1", | |||
| "cheerio": "1.0.0-rc.12", | |||
| "chokidar-cli": "*", | |||
There was a problem hiding this comment.
I think this should be excluded unless we’re actually trying to update dependencies.
There was a problem hiding this comment.
any reason why we can't update chokidar? I see this change every time I npm i so it'd be nice to merge this.
There was a problem hiding this comment.
I've reverted this back to latest for the time being as I guess it's not part of the story?
alexbishop1
requested changes
Oct 19, 2023
alexbishop1
requested changes
Oct 19, 2023
| @@ -128,7 +128,7 @@ | |||
| "chai-arrays": "2.2.0", | |||
| "chai-as-promised": "7.1.1", | |||
| "cheerio": "1.0.0-rc.12", | |||
| "chokidar-cli": "latest", | |||
There was a problem hiding this comment.
This should be * (what it is on master), not latest.
alexbishop1
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
checked: trueproperty from the role-input checkboxes.HOW