Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-11594 - Allow enabling Apple Pay and Google Pay for Sandbox gateway accounts #4153

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

JFSGDS
Copy link
Contributor

@JFSGDS JFSGDS commented Nov 2, 2023

WHAT

Allow enabling Apple Pay and Google Pay for Sandbox gateway accounts

https://payments-platform.atlassian.net/browse/PP-11594

Note:

This is a rework of original pull request #4143. Mainly to make clearer the commits relating to this change as previously, due to rebasing and merge commits, they were spread amongst other unrelated changes.

Also, this PR addresses comments from that review.

HOW

  • Extend existing ‘isDigitalWalletsSuported’ test for ‘Stripe’ and ‘Worldpay’ accounts to include ‘sandbox’ accounts
  • Add feature flag ‘ALLOW_ENABLING_DIGITAL_WALLETS_FOR_SANDBOX_ACCOUNT’ as part of test condition
  • Add unit tests for all sandbox feature flag states

…accounts

- Extend existing 'isDigitalWalletsSuported' test for 'Stripe' and 'Worldpay' accounts to include 'sandbox' accounts
- Add feature flag 'ALLOW_ENABLING_DIGITAL_WALLETS_FOR_SANDBOX_ACCOUNT' as part of test condition
- Remove ‘ALLOW_ENABLING_DIGITAL_WALLETS_FOR_STRIPE_ACCOUNT’ feature toggle as wallet payments for stripe are now live
…accounts

- Add unit tests for all sandbox feature flag states
- Amend tests referring to ‘ALLOW_ENABLING_DIGITAL_WALLETS_FOR_STRIPE_ACCOUNT’ feature flag as wallet payments for Stripe are now live
…accounts

Remove Pact tests that are no longer required
- Remove ‘apple pay toggle with unsupported payment provider request’ test
- Remove ‘google pay toggle with unsupported payment provider request' test
@JFSGDS JFSGDS requested a review from nlsteers November 3, 2023 11:51
@JFSGDS JFSGDS marked this pull request as ready for review November 3, 2023 11:52
Copy link
Collaborator

@nlsteers nlsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOKTM, please squash to a single commit on merge (squash & merge option) 👍🏻

@JFSGDS JFSGDS merged commit 9e34e96 into master Nov 3, 2023
5 checks passed
@JFSGDS JFSGDS deleted the PP-11594-enable-apple-gpay-for-sandbox-accts-rework branch November 3, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants