Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-12055 Update validation styling for transactions search filter #4170

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

iqbalgds
Copy link
Contributor

@iqbalgds iqbalgds commented Jan 23, 2024

  • Use design system guidelines for validation styling.
  • When searching for transactions and the end date < start date:
    • Display an error summary
    • Display an error message around the end date field.
    • Highlight the end date field.
  • The code to carry out the validation was done previously.
  • This PR is to only update the design / styling.

Updated Mobile view with validation error

image

Updated desktop view

image

@iqbalgds iqbalgds marked this pull request as draft January 23, 2024 16:21
@iqbalgds iqbalgds force-pushed the pp-12055-date-range-validation branch 2 times, most recently from 430a3ca to e183c02 Compare January 24, 2024 09:28
@iqbalgds iqbalgds changed the title Pp 12055 date range validation PP-12055 Update validation styling for transactions search filter Jan 24, 2024
- Use design system guidelines for validation styling.
- When searching for transactions and the end date < start date:
  - Display an error summary
  - Display an error message around the `end date` field.
  - Highlight the `end date` field.
- The code to carry out the validation was done previously.
- This PR is to only update the design / styling.
@iqbalgds iqbalgds force-pushed the pp-12055-date-range-validation branch from e183c02 to e4a3ced Compare January 24, 2024 09:51
@iqbalgds iqbalgds marked this pull request as ready for review January 24, 2024 10:04
@iqbalgds iqbalgds merged commit bba494e into master Jan 30, 2024
10 checks passed
@iqbalgds iqbalgds deleted the pp-12055-date-range-validation branch January 30, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants