Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-12395: Validation when creating API key #4397

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

oswaldquek
Copy link
Contributor

@oswaldquek oswaldquek commented Dec 30, 2024

A description is not valid if it's empty or more than 50 chars. Given the text box has a maxLength of 50, the latter validation error can't occur in practice.

Screenshot 2024-12-30 at 12 04 32

Copy link
Contributor

@james-peacock-gds james-peacock-gds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oswaldquek oswaldquek merged commit 5bf46dc into master Dec 30, 2024
14 checks passed
@oswaldquek oswaldquek deleted the PP-12395-create-api-key-validation branch December 30, 2024 13:24
oswaldquek added a commit that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants