PP-12395: Revoke key functionality #4400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oswaldquek
force-pushed
the
PP-12395-revoke-key
branch
3 times, most recently
from
08c4dba to
fc871e4
Compare
oswaldquek
force-pushed
the
PP-12395-revoke-key
branch
from
fc871e4 to
74847f3
Compare
james-peacock-gds
previously requested changes
Jan 3, 2025
| async function post (req, res) { | ||
| if (req.body.revokeApiKey === 'Yes') { // pragma: allowlist secret | ||
| await revokeKey(req.account.id, req.params.tokenLink) | ||
| } |
There was a problem hiding this comment.
The figma says there should be a success notification if the key is revoked so something like [this] maybe?(
)
james-peacock-gds
dismissed
their stale review
we've decided that the success notification can be done in a separate PR
james-peacock-gds
approved these changes
Jan 3, 2025
oswaldquek
added a commit
that referenced
this pull request
Jan 15, 2025
* PP-12395: Cypress test for revoking api keys Cypress tests for #4400
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The revoke key confirmation screen:
This PR does not include cypress tests, which will be in the next PR.