Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-12395: Validation and success notification when revoking API key #4405

Merged

Conversation

oswaldquek
Copy link
Contributor

Validation if nothing is selected:
Screenshot 2025-01-13 at 15 16 02

Notification on successful revocation of key:
Screenshot 2025-01-13 at 15 17 20

@sallytolson1
Copy link

Hey, I just spotted a word missing in the content, the line on Test API keys screen should read 'Use these to connect your test digital service to Pay and to access the reporting API'. Thanks

Copy link
Contributor

@DomBelcher DomBelcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oswaldquek oswaldquek merged commit c13de94 into master Jan 13, 2025
13 of 14 checks passed
@oswaldquek oswaldquek deleted the PP-12395-revoke-key-validation-and-success-notification branch January 13, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants