Rename method to avoid misleading readers #2489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `destroyable_edition?` method had a misleading name, as it isn't a querying method that returns a boolean value—it checks whether an edition is destroyable and, if it isn't, shows a flash message and redirects to the edition's show page. There's already a similar method, `require_assignee_editable`, for checking whether an edition can have its assignee updated, so rename the method to be consistent with that one.
syed-ali-tw
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
destroyable_edition?method had a misleading name, as it isn't aquerying method that returns a boolean value—it checks whether an
edition is destroyable and, if it isn't, shows a flash message and
redirects to the edition's show page.
There's already a similar method,
require_assignee_editable, forchecking whether an edition can have its assignee updated, so rename
the method to be consistent with that one.