Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default to true for restrict_access_by_org feature #2495

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Change default to true for restrict_access_by_org feature #2495

merged 1 commit into from
Jan 15, 2025

Conversation

baisa
Copy link
Contributor

@baisa baisa commented Jan 14, 2025

Trello card

This is not restrict access to Mainstream content for departments outside of GDS

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@baisa baisa force-pushed the enable-permission-restrictions branch from 62d0775 to 8a6b5c1 Compare January 14, 2025 14:58
@mtaylorgds
Change default to true for restrict_access_by_org feature
85d83aa 
This will restrict access to Mainstream content for departments outside
 of GDS.

Now that access is restricted for non-GDS users, the tests have been
 updated to create GDS users by default.
@mtaylorgds mtaylorgds force-pushed the enable-permission-restrictions branch from 8a6b5c1 to 85d83aa Compare January 14, 2025 16:44
ellohez
ellohez approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@ellohez ellohez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baisa baisa marked this pull request as ready for review January 15, 2025 12:36
@baisa baisa merged commit 7753720 into main Jan 15, 2025
12 checks passed
@baisa baisa deleted the enable-permission-restrictions branch January 15, 2025 13:19
ellohez added a commit that referenced this pull request Jan 17, 2025
@ellohez
Revert "Merge pull request #2495 from alphagov/enable-permission-rest…
96bbf63 
…rictions"

This reverts commit 7753720, reversing
changes made to 00b2fe8.

Reverting this change as it is impacting other non-GDS users of Mainstream Publisher that we were unaware of
ellohez added a commit that referenced this pull request Jan 17, 2025
@ellohez
Revert "Merge pull request #2495 from alphagov/enable-permission-rest…
ddb2881 
…rictions"

This reverts commit 7753720, reversing
changes made to 00b2fe8.

Reverting this change as it is impacting other non-GDS users of Mainstream Publisher that we were unaware of
ellohez added a commit that referenced this pull request Jan 17, 2025
@ellohez
Revert "Merge pull request #2495 from alphagov/enable-permission-rest…
8b857db 
…rictions"

This reverts commit 7753720, reversing
changes made to 00b2fe8.

Reverting this change as it is impacting other non-GDS users of Mainstream Publisher that we were unaware of
mtaylorgds added a commit that referenced this pull request Jan 17, 2025
@mtaylorgds
Revert "Merge pull request #2495 from alphagov/enable-permission-rest…
9e0a185 
…rictions"

This reverts commit 7753720, reversing
changes made to 00b2fe8.

Reverting this change as it is impacting other non-GDS users of Mainstream Publisher that we were unaware of
baisa added a commit that referenced this pull request Jan 20, 2025
@baisa
Merge pull request #2500 from alphagov/disable-permission-restrictions
8d85c12 
Revert "Merge pull request #2495 from alphagov/enable-permission-rest…
syed-ali-tw pushed a commit that referenced this pull request Jan 24, 2025
@mtaylorgds @syed-ali-tw
Revert "Merge pull request #2495 from alphagov/enable-permission-rest…
9be3231 
…rictions"

This reverts commit 7753720, reversing
changes made to 00b2fe8.

Reverting this change as it is impacting other non-GDS users of Mainstream Publisher that we were unaware of
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellohez ellohez ellohez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baisa @ellohez @mtaylorgds