Merge pull request #354 from alphagov/use-hidden-not-css-for-expiry-n…

…otices

Use hidden attribute to show/hide expiry notices

CHANGELOG.md

@@ -6,6 +6,7 @@
 - Update gem dependencies.
 - Declare some missing indirect dependencies to prepare for Ruby 3.4. This also resolves some warnings about this at build time.
 - Remove aria-hidden from search label to let assistive technologies see its accessible name
+- Use hidden attribute to show/hide expiry notices instead of just CSS
 
 ## 3.5.0
 

lib/assets/javascripts/_modules/page-expiry.js

@@ -7,8 +7,8 @@
       var isExpired = Date.parse(rawDate) < new Date()
 
       if (isExpired) {
-        $element.find('.page-expiry--not-expired').hide(0)
-        $element.find('.page-expiry--expired').show(0)
+        $element.find('.page-expiry--not-expired').attr('hidden', '')
+        $element.find('.page-expiry--expired').removeAttr('hidden')
       }
     }
   }

lib/assets/stylesheets/modules/_page-review.scss

@@ -24,8 +24,6 @@
 }
 
 .page-expiry--expired {
-  display: none;
-
   padding: govuk-spacing(3);
   margin-top: govuk-spacing(9);
   border: govuk-spacing(1) solid $govuk-error-colour;

lib/source/layouts/_page_review.erb

@@ -12,7 +12,7 @@
     </div>
 
     <% if current_page_review.show_expiry? %>
-    <div class='page-expiry--expired'>
+    <div class='page-expiry--expired' hidden>
       This page was set to be reviewed before <%= format_date current_page_review.review_by %><% if current_page_review.owner_slack %>
        by the page owner <%= link_to current_page_review.owner_slack, current_page_review.owner_slack_url %><% end %>.
       This might mean the content is out of date.