Implement Worldwide Organisation offices as multi-part content #8844
Conversation
brucebolt
force-pushed
the
ww-office-multipart
branch
3 times, most recently
from
fe7478e to
0848ad0
Compare
This code will be used to embed Worldwide Offices into the multi-part content item for Worldwide Organisations, so needs to be extracted into a helper to enable this.
brucebolt
force-pushed
the
ww-office-multipart
branch
2 times, most recently
from
4a6ac17 to
4bdb56e
Compare
| access_and_opening_times: Whitehall::GovspeakRenderer.new.govspeak_to_html(worldwide_org.reload.home_page_offices.first.access_and_opening_times), | ||
| contact_content_id: worldwide_org.reload.home_page_offices.first.contact.content_id, | ||
| services: [], | ||
| slug: worldwide_org.reload.home_page_offices.first.slug, |
There was a problem hiding this comment.
Just checking is this the full path offices/office-1 or just office-1?
There was a problem hiding this comment.
I haven't looked at your Gov Frontend code yet, but in the spike I did the other week, this would have had to be offices/office-1
There was a problem hiding this comment.
It's offices/office-1. I wasn't really sure whether to add the offices/ here or in the frontend app.
I went with the frontend app in the end, as it isn't really part of the slug.
I wonder whether full base path (e.g. /world/organisation/foo/offices/bar) might actually be better than slug?
There was a problem hiding this comment.
I kind of see it relative to the content item it's part of... if that makes sense? So offices/office-1 makes the most sense to me
There was a problem hiding this comment.
Yeah, that's true. Let's go for office/office-1 here, then I can remove office/ from the Government Frontend code.
brucebolt
force-pushed
the
ww-office-multipart
branch
from
4bdb56e to
8b7196c
Compare
| worldwide_offices.map do |worldwide_office| | ||
| worldwide_office_details(worldwide_office).merge( | ||
| contact_content_id: worldwide_office.contact.content_id, | ||
| slug: "office/#{worldwide_office.slug}", |
There was a problem hiding this comment.
Is there any way we could DRY this up to avoid hardcoding it here.
Maybe raising the path as a constant in WorldwideOffice, or something?
There was a problem hiding this comment.
I don't know what the chance of someone changing the office path is, but if they did, then this would break
There was a problem hiding this comment.
Good point. I've used the base_path method of the WorldwideOffice, then gsubbed out the base path of the WorldwideOrganisation and a slash.
brucebolt
force-pushed
the
ww-office-multipart
branch
from
8b7196c to
eeb8da7
Compare
We are currently assuming all worldwide offices exist under the same base path, which is not the case for those associated with editionable worldwide organisations. Therefore updating the base path method so the correct path is returned for offices associated with either editionable and non-editionable worldwide organisations.
This includes the content of the worldwide offices in the worldwide organisation page, allowing us to render them from a single content item. Depends on alphagov/publishing-api#2638.
…ions This includes the content of the worldwide offices in the editionable worldwide organisation page, allowing us to render them from a single content item. Depends on alphagov/publishing-api#2638.
brucebolt
force-pushed
the
ww-office-multipart
branch
from
eeb8da7 to
5c8e502
Compare
We are switching Worldwide Organisations to include the content of their offices in the main content item for the organisation. This adds that into the presenters for these content types.
In a later PR, we will remove the links and update routes once the rendering code (alphagov/government-frontend#3095) has been updated.
Depends on alphagov/publishing-api#2638.
Trello card
Follow these steps if you are doing a Rails upgrade.