fix(WebAppProvider): loading script

altiore · Nov 13, 2023 · ae5f823 · ae5f823
1 parent 9eacc63
commit ae5f823
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@altiore/twa",
-  "version": "1.2.8",
+  "version": "1.2.9",
   "description": "React components for Telegram WebApp",
   "source": "./src/index.ts",
   "type": "module",

diff --git a/src/WebAppProvider.tsx b/src/WebAppProvider.tsx
@@ -71,7 +71,7 @@ const WebAppProvider = ({
 		return () => window.removeEventListener('beforeunload', forceHideButtons);
 	}, [options?.smoothButtonsTransition, webApp]);
 
-	const [isLoading, setIsLoading] = useState(true);
+	const [isLoading, setIsLoading] = useState(false);
 	const [isLoaded, setIsLoaded] = useState(false);
 
 	const subscribeScriptLoading = useCallback(
@@ -94,11 +94,17 @@ const WebAppProvider = ({
 				};
 
 				scriptEle.addEventListener('load', successListener);
-
 				scriptEle.addEventListener('error', errorListener);
+
+				return () => {
+					scriptEle.removeEventListener('load', successListener);
+					scriptEle.removeEventListener('error', errorListener);
+				};
 			} catch (err) {
 				console.error(err);
 			}
+
+			return () => {};
 		},
 		[setIsLoaded, setIsLoading, setWebApp],
 	);
@@ -110,7 +116,7 @@ const WebAppProvider = ({
 			}
 			setIsLoading(true);
 			const existingScripts: NodeListOf<HTMLScriptElement> =
-				window.document.querySelectorAll(`script[src~='${SCRIPT}']`);
+				window.document.querySelectorAll(`script[src='${SCRIPT}']`);
 			if (existingScripts[0]) {
 				return subscribeScriptLoading(existingScripts[0]);
 			}
@@ -129,6 +135,8 @@ const WebAppProvider = ({
 			setIsLoaded(false);
 			setIsLoading(false);
 		}
+
+		return () => {};
 	}, [subscribeScriptLoading, isLoading, isLoaded]);
 
 	const systemValue = useMemo(createSystemContextValue, []);