fix: handle JNI java exceptions properly in client_core #2563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShootingKing-AM
changed the title
zmerp
requested changes
Dec 10, 2024
Comment on lines
+13
to
+19
| fn env_call_method_handled<'local>( | ||
| env: &mut JNIEnv<'local>, | ||
| object: &JObject, | ||
| method: &str, | ||
| sig: &str, | ||
| args: &[JValue], | ||
| ) -> Result<JValueOwned<'local>, Error> { |
There was a problem hiding this comment.
Usually i follow the path of fewer parameters when making a function to abstract away some code. In this case it would be much easier to make a function taking a jni::Result<T> and return a anyhow::Result<T>. Inside the function, don't panic because you don't know the intention of the caller, even if we always unwrap, don't expect anything. Instead limit this function to just transform the error.
Actually, before doing this, check if just calling .to_any() at the caller site is enough (with the purpose of making the error message clearer). This function is defined in alvr_common. Other things you could do is to play with different printing methods (using {} or {:?} placeholders with format!())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR
After using the PR
before