zmerp-staging #2625
zmerp-staging #2625
Conversation
I can't find an easy way of doing this unfortunately. The macro takes a |
zmerp
force-pushed
the
zmerp-staging
branch
2 times, most recently
from
0ed9f86 to
ce9c7e4
Compare
|
Failure on warnings works |
|
|
||
| if !messages.is_empty() { | ||
| panic!("ci clippy produced warnings"); | ||
| } |
There was a problem hiding this comment.
I'm pretty sure there's also other compiler messages than diagnostics (you'd have to check the rustc docs tho), but we should only cause a ci failure when a diagnostic is actually emitted.
There was a problem hiding this comment.
I checked and there's actually some, but they're not very frequent. Either way the diagnostic message filtering should be moved to the main filter (or a second stacked filter_map), as that'll fully ensure that causes no issues.
| if let WiredConnectionStatus::NotReady(m) = status { | ||
| dbg_connection!("handshake_loop: Wired connection not ready: {m}"); | ||
| #[cfg_attr(not(debug_assertions), allow(unused_variables))] | ||
| if let WiredConnectionStatus::NotReady(s) = status { |
There was a problem hiding this comment.
Could make this an expect ig
There was a problem hiding this comment.
Right. All allows should be turned into expect actually.
|
But the moving the warning handling was more of a suggestion, if it doesn't work then it doesn't work. |
No description provided.