New IInputStream to read from NetCDF: CInputStream_NetCDF #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compile has warnings. Will fix.
5tefan
changed the title
5tefan
changed the title
Previously, was processing a ton of individual files each with a call to fpf. Although admittedly fpf was not the slow part, this was the best way to realize an accelleration. Can avoid many calls through the Python wrapper, instead, keep the calls within fpf, have all the files write to one writer node, and then only one call to ccsdspy after.
To support APID discovery and browsing.
Conflicts: Makefile
- Updates Makefile_nocurl for Resize and APIDlist - Reconcile Makefile differences - Explicitly include stdlib - Adds NETCDF and APIDlist to class_factory
Conflicts: Makefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Please consider this contribution which adds a new input stream node:
CInputStream_NetCDF.CInputStream_NetCDF takes the following parameters in the ini:
I've wrapped the functionality in a USE_NETCDF preprocessor directive, so (I think) it's possible to compile without the NetCDF-C dependency. I've made the default Makefile build the NetCDF version. I would be happy to extract this instead to a Makefile_netcdf or something if you would prefer not to require NetCDF to build the main Makefile.
Thanks,
Stefan