Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new report LANDA Power Users (LAN-866) #270

Merged
merged 2 commits into from
Jan 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/permissions.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,9 @@ The default way to achieve this would be adding a link field from **Tag** to **O
To prevent this, we added a table named **Tag Organization** to the **Tag** doctype. When a new tag is created, the creator's organization is added to this table. We also added a custom permission query which checks if the user's organization is in this table. This way users can only see tags created by people in the same organization.

See https://github.com/alyf-de/landa/pull/254 for details.

### Monitoring

Usually, most users should be restricted to seeing data of their own organization only. However, some users are allowed to see data of other organizations.

For monitoring users with high permissions, we created a report named **LANDA Power Users**. It shows all users with high permissions, and which organizations they are allowed to see. Excluded are the default users **Administrator** and **Guest**. Also, users who are members of a regional organization (e.g. AVL-000) and have permissions for that regional organization (e.g. AVL) are excluded.
Empty file.
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// Copyright (c) 2025, ALYF GmbH and contributors
// For license information, please see license.txt
/* eslint-disable */

frappe.query_reports["LANDA Power Users"] = {
"filters": [

]
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
{
"add_total_row": 0,
"columns": [],
"creation": "2025-01-10 16:06:59.329435",
"disable_prepared_report": 0,
"disabled": 0,
"docstatus": 0,
"doctype": "Report",
"filters": [],
"idx": 0,
"is_standard": "Yes",
"letter_head": "Extended Information in Footer",
"modified": "2025-01-10 16:06:59.329435",
"modified_by": "Administrator",
"module": "Organization Management",
"name": "LANDA Power Users",
"owner": "Administrator",
"prepared_report": 0,
"ref_doctype": "User",
"report_name": "LANDA Power Users",
"report_type": "Script Report",
"roles": [
{
"role": "System Manager"
},
{
"role": "LANDA State Organization Employee"
}
]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
# Copyright (c) 2025, ALYF GmbH and contributors
# For license information, please see license.txt

import frappe
from frappe import _
from frappe.query_builder.functions import Substring
from pypika.functions import Coalesce
from pypika.terms import Not


def execute(filters=None):
return get_columns(), get_data()


def get_data():
User = frappe.qb.DocType("User")
UserPermission = frappe.qb.DocType("User Permission")

org_permissions = (
frappe.qb.from_(UserPermission)
.select(UserPermission.user, UserPermission.for_value)
.where(UserPermission.allow == "Organization")
.where(UserPermission.apply_to_all_doctypes == 1)
)

query = (
frappe.qb.from_(User)
.left_join(org_permissions)
.on(User.name == org_permissions.user)
.select(
User.name,
User.organization,
Coalesce(org_permissions.for_value, "All Organizations").as_("permissions_for"),
)
.where(User.name.notin(["Administrator", "Guest"]))
.where(User.enabled == 1)
.where(
(Substring(org_permissions.for_value, 1, 7) != Substring(User.organization, 1, 7))
| (org_permissions.for_value.isnull())
)
.where(
# Exclude lines like "Member of AVL-000. Permissions for AVL" (regional org management)
Not(
(Substring(User.organization, 5, 7) == "000")
& (Substring(User.organization, 1, 3) == org_permissions.for_value)
)
)
.orderby(User.name)
)

return query.run()


def get_columns():
return [
{
"fieldname": "user",
"label": _("User"),
"fieldtype": "Link",
"options": "User",
},
{
"fieldname": "member_of",
"label": _("Member of"),
"fieldtype": "Link",
"options": "Organization",
},
{
"fieldname": "permissions_for",
"label": _("Permissions for"),
"fieldtype": "Data",
},
]
2 changes: 2 additions & 0 deletions landa/translations/de.csv
Original file line number Diff line number Diff line change
Expand Up @@ -107,3 +107,5 @@ Statement of Fees and Payments,Beitragsabrechnung,
This Statement of Fees and Payments already exists: {0},Diese Beitragsabrechnung existiert bereits: {0},
This Statement of Fees and Payments must be linked to an Organization,Diese Beitragsabrechnung muss mit einem Verein verknüpft sein,
Group By Fish Species,Nach Fischart gruppieren,
Member of,Mitglied von,
Permissions for,Berechtigungen für,
Loading