Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable commented code chunks in several notebooks #419

Merged
merged 28 commits into from
Oct 20, 2023

Conversation

rmshaffer
Copy link
Contributor

@rmshaffer rmshaffer commented Oct 17, 2023

Issue #, if available:

Description of changes:
This is a resubmission of PR #372 (which was reverted in PR #414) after merging and resolving conflicts with #408.

The merge conflict resolution was limited to the file 2_Graph_optimization_with_QAOA.ipynb. All other files are unchanged from PR #372.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rmshaffer rmshaffer marked this pull request as ready for review October 17, 2023 17:40
@rmshaffer rmshaffer requested a review from a team as a code owner October 17, 2023 17:40
ajberdy
ajberdy previously approved these changes Oct 17, 2023
@krneta
Copy link
Contributor

krneta commented Oct 17, 2023

Sorry, can we hold off on merging this until after we're re-enabled the tests?

@rmshaffer rmshaffer marked this pull request as draft October 17, 2023 17:58
@krneta
Copy link
Contributor

krneta commented Oct 20, 2023

Hey Ryan, sorry about the long wait, but I think we've enabled the tests now where this should be working. Can you please verify?

@rmshaffer rmshaffer marked this pull request as ready for review October 20, 2023 18:54
@rmshaffer
Copy link
Contributor Author

@krneta @ajberdy finished merging with latest changes from main and all tests are passing, please approve and merge if you agree that this is ready to go! Thanks for the help.

@rmshaffer rmshaffer merged commit c74906c into main Oct 20, 2023
@rmshaffer rmshaffer deleted the rmshaffer/uncomment-code-2 branch October 20, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants