Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): use semver for @babel/eslint-parser #140

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

smackfu
Copy link
Member

@smackfu smackfu commented Jan 9, 2025

Description

Use a semver range for @babel/eslint-parser.

Please make sure that the PR fulfills these requirements

  • I checked that there aren't other open Pull Requests for the same update/change.
  • My code follows the code style of this project.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • Rule changes includes a comment to describe the reasoning behind the change.
  • PR contains a single rule change.

Motivation and Context

When this was added in #94, a fixed version was used rather than a semver. There is no rationale for this in the PR, so I assume this was a mistake.

As a result, every consuming package has a fixed version:

$ npm ls @babel/eslint-parser
...
└─┬ eslint-config-amex@16.5.0
  └── @babel/eslint-parser@7.16.5

@babel/eslint-parser@7.24.5 is required to support eslint@9 so this is part of #132

How Has This Been Tested?

Packed and verified version in consumers is no longer fixed.

$ npm ls @babel/eslint-parser
...
└─┬ eslint-config-amex@16.5.0
  └── @babel/eslint-parser@7.25.9

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

@smackfu smackfu requested a review from a team January 10, 2025 14:43
@smackfu smackfu enabled auto-merge (squash) January 10, 2025 14:43
@smackfu smackfu requested a review from a team January 10, 2025 14:53
@smackfu smackfu merged commit af799e2 into americanexpress:main Jan 10, 2025
5 checks passed
oneamexbot added a commit that referenced this pull request Jan 10, 2025
## [16.6.1](v16.6.0...v16.6.1) (2025-01-10)

### Bug Fixes

* **deps:** use semver for @babel/eslint-parser ([#140](#140)) ([af799e2](af799e2))
@oneamexbot
Copy link
Contributor

🎉 This PR is included in version 16.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants