I made changes in dropdown menu and made "BE" Link working. #625
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you, @rahul803213, for creating this pull request and contributing to GitHub-ReadMe! 💗 Our review team will thoroughly review the pull request and will reach out to you soon! 😇 |
WalkthroughWalkthroughThis update involves introducing a new page component for the Bachelor of Engineering program and adjusting the navigation flow by changing the link in the navbar to direct users to the new page. It also addresses a visibility issue with the dropdown menu in the navbar by modifying its background and text color for better readability. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (1)
components/common/Navbar.js (1)
Line range hint
1-1: Consider cleaning up commented-out code and addressing TODO comments to improve code clarity and maintainability.
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- components/common/Navbar.js (1 hunks)
- pages/courses/be/index.js (1 hunks)
- styles/Navbar.module.css (3 hunks)
Files skipped from review due to trivial changes (1)
- styles/Navbar.module.css
Additional comments not posted (2)
pages/courses/be/index.js (1)
1-97: The structure and imports in this newBTechcomponent are well-organized and follow React best practices.components/common/Navbar.js (1)
228-228: The update to the link destination in the navigation bar is correctly implemented.
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- components/common/Navbar.js (2 hunks)
- pages/courses/be/index.js (1 hunks)
- pages/courses/config.js (1 hunks)
- styles/Navbar.module.css (2 hunks)
Files skipped from review due to trivial changes (1)
- pages/courses/config.js
Files skipped from review as they are similar to previous changes (3)
- components/common/Navbar.js
- pages/courses/be/index.js
- styles/Navbar.module.css
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- components/common/Navbar.js (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- components/common/Navbar.js
|
|
Fix #619
Description
I made changes in DropDown menu and corrected its background color so that it not create any visibility issue.
Previously "BE" link was not working so i created a folder "BE" in pages and made index.js and write the content for the page.Now its behaviour is correct.
Pull Request Checklist
Please make sure that your PR meets the following requirements:
[ ✅] The app is working correctly after applying the changes.
[ ✅] The app is responsive and displays properly on different screen sizes and devices.
[ ✅] The changes are thoroughly documented in the appropriate files or documentation sections.
[✅ ] The coding conventions and style guidelines are followed consistently.
Checklist
Please check all applicable boxes and provide any additional information if needed.
[ ✅] I have tested the changes locally and ensured that the app is functioning as expected.
[✅ ] I have verified that the app is responsive and looks good on various screen sizes and devices.
[ ✅] I have reviewed the documentation and ensured that it accurately reflects the changes made.
[✅ ] I have followed the coding conventions and style guidelines defined in the project.
[ ✅] I have run the automated tests and all of them pass.
[ ✅] I have considered the performance implications of the changes made.
[ ✅] I have considered the security implications of the changes made.
[ ✅] I have checked for any potential regressions or side effects caused by the changes.
[ ✅] I have performed a self-review of my code.
[✅ ] Starred the repository.
[✅ ] Added My Name to the Contributor's List.
[✅ ] Followed the repository's Contributing Guidelines.
[ ✅] I ran the app and tested it locally to verify that it works as expected.
Additional Notes(Optional)
Please provide any additional information or context that may be helpful for reviewing the pull request.
Related Issues
Please list any related issues or pull requests that are associated with this pull request.
Reviewers
Please tag the relevant team members or reviewers who should review this pull request.