add support for LTC7841 #2397

MCabuena · 2024-12-12T02:31:47Z

Pull Request Description

Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.

PR Type

Bug fix (change that fixes an issue)
New feature (change that adds new functionality)
Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

I have followed the Coding style guidelines
I have performed a self-review of the changes
I have commented my code, at least hard-to-understand parts
I have build all projects affected by the changes in this PR
I have tested in hardware affected projects, at the relevant boards
I have signed off all commits from this PR
I have updated the documentation (wiki pages, ReadMe etc), if applies

kister-jimenez · 2024-12-12T23:57:39Z

/AzurePipelines run

azure-pipelines · 2024-12-12T23:57:52Z

Azure Pipelines successfully started running 2 pipeline(s).

MCabuena · 2024-12-13T01:51:43Z

V2:

Removed from src.mk ltc7841_regs.c and ltc7841_regs.h requirement for building

kister-jimenez · 2024-12-13T02:01:32Z

/AzurePipelines run

azure-pipelines · 2024-12-13T02:01:45Z

Azure Pipelines successfully started running 2 pipeline(s).

MCabuena · 2024-12-13T09:03:35Z

V3:

fixed src.mk file inside ltc7841 project folder

kister-jimenez · 2024-12-13T09:25:07Z

/AzurePipelines run

azure-pipelines · 2024-12-13T09:25:20Z

Azure Pipelines successfully started running 2 pipeline(s).

drivers/power/ltc7841/ltc7841.h

CiprianRegus · 2024-12-13T09:11:00Z

drivers/power/ltc7841/ltc7841.c

+	uint8_t read_length;
+	uint8_t write_length = 1;
+	uint8_t size = get_register_size(cmd);
+	uint8_t write_buffer[write_length];


doesn't need to be an array

drivers/power/ltc7841/ltc7841.c

CiprianRegus · 2024-12-13T09:11:43Z

drivers/power/ltc7841/ltc7841.c

+	if (ret)
+		return ret;
+	// read part of write_read, 1 at the end for stop bit sending
+	ret = no_os_i2c_read(desc->comm_desc, g_i2c0_read_buffer, read_length, 1);


You should store the register value in data.

drivers/power/ltc7841/ltc7841.c

CiprianRegus · 2024-12-13T09:25:12Z

drivers/power/ltc7841/iio_ltc7841.c

+static struct iio_attribute ltc7841_chan_attrs[] = {
+	{
+		.name = "raw",
+		.show = ltc7841_iio_read_raw
+	},
+	END_ATTRIBUTES_ARRAY
+};


Is the scale of every channel equal to 1? Otherwise, you also need the scale attribute here.

The scale of every channel is the same at 10mV per bit.

on my next commit, I'll add as you stated below a scale attribute for the channel

When implementing review suggestions, you don't need to create a new commit (unless you add new functionality, which should have its own commit). Just modify the current one and push the changes again. After that, you should add a changelog comment in this PR stating what you did since the last push.

drivers/power/ltc7841/iio_ltc7841.c

CiprianRegus · 2024-12-13T09:28:04Z

drivers/power/ltc7841/iio_ltc7841.c

+	}
+	case LTC7841_IIO_IIN_CHAN:
+		ret = ltc7841_reg_read(ltc7841, (uint8_t)LTC7841_READ_IIN, read_value);
+		if (0 == ret) {


Use inverse logic:

if (ret) break;

drivers/power/ltc7841/iio_ltc7841.c

CiprianRegus · 2024-12-13T13:48:19Z

drivers/power/ltc7841/ltc7841.h

+#define PEC_SIZE                    0x100
+#define BYTE_LENGTH                 1
+#define WORD_LENGTH                 2


Add the LTC7841_ prefix. Otherwise, generic names like these could create conflicts with other macros.

CiprianRegus · 2024-12-13T13:51:06Z

projects/ltc7841/src/common/common_data.c

+	.max_speed_hz   = LTC7841_I2C_CLK_SPEED,
+	.slave_address  = LTC7841_I2C_ADDR,
+	.platform_ops   = &max_i2c_ops,
+	.extra          = (void *)&ltc7841_i2c_extra,


No need to cast.

unresolving this conversation since it's not resolved yet.

MCabuena · 2024-12-17T03:49:15Z

V4:

changed commenting style to /* */
removed void in common_data.c for ltc7841_i2c_extra
removed PEC_SIZE since this device doesn't support PEC
added LTC7841_ name to BYTE_LENGTH and WORD_LENGTH in ltc7841.h
when computing for current input and current output, unit usage is now in uA for initial calculations, only when calculating for scale values does it show in A
changed iio_ltc7841.c all reverse logic for checking ret
added scaled value as an attribute
functions in ltc7841.c now return directly
changed write_buffer into a uint8_t type only, and not as an array
changed license file of ltc7841.h

buha · 2024-12-17T10:23:18Z

/AzurePipelines run

azure-pipelines · 2024-12-17T10:23:31Z

Azure Pipelines successfully started running 2 pipeline(s).

drivers/power/ltc7841/ltc7841.c

drivers/power/ltc7841/ltc7841.h

projects/ltc7841/src.mk

projects/ltc7841/src/platform/maxim/platform_src.mk

MCabuena · 2024-12-18T02:24:40Z

V5:

changed src.mk file to use NO_OS_INC_DIRS instead of INC +=
removed ltc7841_reg_st inside ltc7841_init_param
added a blank space before the final return as suggested
added a space in between the {} of functions

kister-jimenez · 2024-12-18T02:26:19Z

/AzurePipelines run

azure-pipelines · 2024-12-18T02:26:32Z

Azure Pipelines successfully started running 2 pipeline(s).

kister-jimenez · 2025-01-10T02:46:39Z

Hi,

I'm not sure why my README file inside drivers/power/README.rst cannot be found. I'll try recommitting the same files and check if the issue happens again.

That's the cause of the issue, but if you check the 3rd commit, the file is included.

You have a typo in part number inside the README.rst.

You can leave as it is for now, I'm currently going through the code and submit the comments today.

kister-jimenez · 2025-01-15T06:01:21Z

/AzurePipelines run

azure-pipelines · 2025-01-15T06:01:38Z

Azure Pipelines successfully started running 2 pipeline(s).

projects/ltc7841/src/common/common_data.c

drivers/power/ltc7841/iio_ltc7841.h

drivers/power/ltc7841/iio_ltc7841.c

projects/ltc7841/src/platform/maxim/astyle.exe

projects/ltc7841/src/common/common_data.c

kister-jimenez · 2025-01-15T06:53:59Z

projects/ltc7841/src/common/common_data.c

+	.max_speed_hz   = LTC7841_I2C_CLK_SPEED,
+	.slave_address  = LTC7841_I2C_ADDR,
+	.platform_ops   = &max_i2c_ops,
+	.extra          = (void *)&ltc7841_i2c_extra,


unresolving this conversation since it's not resolved yet.

projects/ltc7841/src/examples/basic/basic_example.c

drivers/power/ltc7841/ltc7841.h

projects/ltc7841/src/examples/iio_example/iio_example.c

MCabuena · 2025-01-21T08:36:17Z

V9

changed CURRENT_SCALE to manual computation with a parameter input for rsense : RSENSE_VALUE_DC2798A, in case user wants to use a different rsense value from DC2798A, he can change the input to common_data.c for the LTC7841_rsense_value
removed astyle.exe files and astyle_config files
changed int32_t type to int32 in iio_ltc7841.c file for the return type
hopefully all nits?

kister-jimenez · 2025-01-21T08:45:22Z

/AzurePipelines run

azure-pipelines · 2025-01-21T08:45:36Z

Azure Pipelines successfully started running 2 pipeline(s).

buha

It looks good but you'll have to update the project to the new project infrastructure.

Here's the PR with the changes with 3 modified projects as example: #2412

And here's a pending PR where I gave feedback with pretty much that needs to be changed, same applies to your PR.
#2411

kister-jimenez

The EXAMPLE= has been implemented in the previous comments so I just added the comments related to the other changes needed for the recently merged examples infra.

Addition minor changes on the rsense placement.

drivers/power/ltc7841/iio_ltc7841.c

drivers/power/ltc7841/ltc7841.h

projects/ltc7841/src/common/common_data.c

projects/ltc7841/src/examples/iio_example/iio_example.c

projects/ltc7841/src/examples/basic/basic_example.c

projects/ltc7841/src/platform/platform_includes.h

projects/ltc7841/src.mk

projects/ltc7841/src/examples/examples_src.mk

projects/ltc7841/src/platform/maxim/main.c

MCabuena · 2025-01-23T03:38:07Z

V10

moved rsense parameter to ltc7841_iio_init parameter
followed Kister's instructions to change the project files

kister-jimenez · 2025-01-23T04:59:58Z

/AzurePipelines run

azure-pipelines · 2025-01-23T05:01:07Z

Azure Pipelines successfully started running 2 pipeline(s).

Add initial header and source files for LTC7841 driver Signed-off-by: Marvin Neil Cabuenas <MarvinNeil.Cabuenas@analog.com>

Add initial header and source file for LTC7841 IIO driver. Signed-off-by: Marvin Neil Cabuenas <MarvinNeil.Cabuenas@analog.com>

Add README.rst documentation file for LTC7841 alongside other documentation related files. Signed-off-by: Marvin Neil Cabuenas <MarvinNeil.Cabuenas@analog.com>

MCabuena · 2025-01-23T07:33:03Z

V11

removed \ at the end of SRCS += $(DRIVERS)/power/ltc7841/iio_ltc7841.c in examples_src.mk

kister-jimenez · 2025-01-23T09:02:47Z

/AzurePipelines run

azure-pipelines · 2025-01-23T09:03:02Z

Azure Pipelines successfully started running 2 pipeline(s).

Add initial project files for both basic and IIO examples for LTC7841. Signed-off-by: Marvin Neil Cabuenas <MarvinNeil.Cabuenas@analog.com>

Add README.rst documentation file for project alongside other documentation related files. Signed-off-by: Marvin Neil Cabuenas <MarvinNeil.Cabuenas@analog.com>

MCabuena · 2025-01-23T23:15:30Z

V12

performed astyle.exe --options= on basic_example.c

kister-jimenez · 2025-01-24T03:29:15Z

/AzurePipelines run

azure-pipelines · 2025-01-24T03:29:29Z

Azure Pipelines successfully started running 2 pipeline(s).

MCabuena marked this pull request as ready for review December 12, 2024 02:33

MCabuena requested review from buha, CiprianRegus, dbogdan, amiclaus, rbolboac and danmois as code owners December 12, 2024 02:33

MCabuena force-pushed the ltc7841_my_changes_to_run_ci branch from fcc8863 to 5b005cb Compare December 13, 2024 01:40

MCabuena force-pushed the ltc7841_my_changes_to_run_ci branch from c57b81e to 16af219 Compare December 13, 2024 08:46

CiprianRegus reviewed Dec 13, 2024

View reviewed changes

MCabuena force-pushed the ltc7841_my_changes_to_run_ci branch from 298e71f to 6423294 Compare December 17, 2024 03:34

buha reviewed Dec 17, 2024

View reviewed changes

drivers/power/ltc7841/ltc7841.c Show resolved Hide resolved

buha reviewed Dec 17, 2024

View reviewed changes

drivers/power/ltc7841/ltc7841.c Show resolved Hide resolved

buha reviewed Dec 17, 2024

View reviewed changes

drivers/power/ltc7841/ltc7841.h Outdated Show resolved Hide resolved

projects/ltc7841/src.mk Outdated Show resolved Hide resolved

projects/ltc7841/src/platform/maxim/platform_src.mk Outdated Show resolved Hide resolved

MCabuena force-pushed the ltc7841_my_changes_to_run_ci branch from 34f8560 to 3674149 Compare December 18, 2024 02:13

MCabuena force-pushed the ltc7841_my_changes_to_run_ci branch from b0d0011 to 228b995 Compare January 15, 2025 05:28

kister-jimenez reviewed Jan 15, 2025

View reviewed changes

MCabuena force-pushed the ltc7841_my_changes_to_run_ci branch from 6646390 to 7d0d840 Compare January 21, 2025 08:23

buha requested changes Jan 22, 2025

View reviewed changes

kister-jimenez reviewed Jan 22, 2025

View reviewed changes

MCabuena force-pushed the ltc7841_my_changes_to_run_ci branch 2 times, most recently from 1e50ae5 to 34a77d8 Compare January 23, 2025 03:34

drivers: power: ltc7841: Add support for LTC7841

dc95dcb

Add initial header and source files for LTC7841 driver Signed-off-by: Marvin Neil Cabuenas <MarvinNeil.Cabuenas@analog.com>

MCabuena force-pushed the ltc7841_my_changes_to_run_ci branch from 196fcc0 to dc95dcb Compare January 23, 2025 07:13

MCabuena added 2 commits January 23, 2025 15:14

drivers: power: ltc7841: Add IIO support for LTC7841

008349c

Add initial header and source file for LTC7841 IIO driver. Signed-off-by: Marvin Neil Cabuenas <MarvinNeil.Cabuenas@analog.com>

drivers: power: ltc7841: Add README for LTC7841

4e16e8d

Add README.rst documentation file for LTC7841 alongside other documentation related files. Signed-off-by: Marvin Neil Cabuenas <MarvinNeil.Cabuenas@analog.com>

MCabuena force-pushed the ltc7841_my_changes_to_run_ci branch from 045ffa0 to 6b453ea Compare January 23, 2025 07:41

projects: ltc7841: Add project for LTC7841

ec9a451

Add initial project files for both basic and IIO examples for LTC7841. Signed-off-by: Marvin Neil Cabuenas <MarvinNeil.Cabuenas@analog.com>

MCabuena force-pushed the ltc7841_my_changes_to_run_ci branch from dc99896 to ec9a451 Compare January 23, 2025 23:11

projects: ltc7841: Add documentation for LTC7841 examples

4d00146

Add README.rst documentation file for project alongside other documentation related files. Signed-off-by: Marvin Neil Cabuenas <MarvinNeil.Cabuenas@analog.com>

add support for LTC7841 #2397

Are you sure you want to change the base?

add support for LTC7841 #2397

Conversation

MCabuena commented Dec 12, 2024 • edited Loading

Pull Request Description

PR Type

PR Checklist

kister-jimenez commented Dec 12, 2024

azure-pipelines bot commented Dec 12, 2024

MCabuena commented Dec 13, 2024

kister-jimenez commented Dec 13, 2024

azure-pipelines bot commented Dec 13, 2024

MCabuena commented Dec 13, 2024

kister-jimenez commented Dec 13, 2024

azure-pipelines bot commented Dec 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MCabuena commented Dec 17, 2024

buha commented Dec 17, 2024

azure-pipelines bot commented Dec 17, 2024

MCabuena commented Dec 18, 2024

kister-jimenez commented Dec 18, 2024

azure-pipelines bot commented Dec 18, 2024

kister-jimenez commented Jan 10, 2025 • edited Loading

kister-jimenez commented Jan 15, 2025

azure-pipelines bot commented Jan 15, 2025

Choose a reason for hiding this comment

MCabuena commented Jan 21, 2025

kister-jimenez commented Jan 21, 2025

azure-pipelines bot commented Jan 21, 2025

buha left a comment • edited Loading

Choose a reason for hiding this comment

kister-jimenez left a comment

Choose a reason for hiding this comment

MCabuena commented Jan 23, 2025

kister-jimenez commented Jan 23, 2025

azure-pipelines bot commented Jan 23, 2025

MCabuena commented Jan 23, 2025

kister-jimenez commented Jan 23, 2025

azure-pipelines bot commented Jan 23, 2025

MCabuena commented Jan 23, 2025

kister-jimenez commented Jan 24, 2025

azure-pipelines bot commented Jan 24, 2025

MCabuena commented Dec 12, 2024 •

edited

Loading

kister-jimenez commented Jan 10, 2025 •

edited

Loading

buha left a comment •

edited

Loading