drivers: frequency: add support for ADMFM2000 #2416
+971
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranechita
requested review from
buha,
CiprianRegus,
dbogdan,
amiclaus,
rbolboac and
danmois
as code owners
buha
reviewed
Jan 17, 2025
ranechita
force-pushed
the
admfm2000_dev
branch
from
95003f6 to
517f9d5
Compare
|
v2:
|
The ADMFM2000 is a dual-channel microwave downconverter, with input RF and local oscillator (LO) frequency ranges covering 5 GHz to 32 GHz, with an output intermediate frequency (IF) frequency range from 0.5 GHz to 8 GHz. Added driver and iio_support. Signed-off-by: Ramona Alexandra Nechita <ramona.nechita@analog.com>
ranechita
force-pushed
the
admfm2000_dev
branch
from
517f9d5 to
d350712
Compare
|
v3:
|
CiprianRegus
approved these changes
Jan 23, 2025
|
There seems to be an error regarding the documentation: |
amiclaus
reviewed
Jan 23, 2025
| */ | ||
| int32_t admfm2000_set_channel_mode(struct admfm2000_dev *dev, uint8_t config); | ||
|
|
||
| #endif /* SRC_ADMFM2000_H_ */ |
|
|
||
| /** | ||
| * @brief Initialize the admfm2000 device. | ||
| * @param device - The device structure. |
There was a problem hiding this comment.
all these header comments should go in the .c file as you did in the iio_admfm200.c
| * @brief Header file for admfm2000 Driver. | ||
| * @author Ramona Nechita (ramona.nechita@analog.com) | ||
| ******************************************************************************** | ||
| * Copyright 2024(c) Analog Devices, Inc. |
| * @brief Implementation of admfm2000 Driver. | ||
| * @author Ramona Nechita (ramona.nechita@analog.com) | ||
| ******************************************************************************** | ||
| * Copyright 2024(c) Analog Devices, Inc. |
| * @brief Implementation of admfm2000 IIO Driver. | ||
| * @author Ramona Nechita (ramona.nechita@analog.com) | ||
| ******************************************************************************** | ||
| * Copyright 2024(c) Analog Devices, Inc. |
| * @brief Header file for admfm2000 IIO Driver. | ||
| * @author Ramona Nechita (ramona.nechita@analog.com) | ||
| ******************************************************************************** | ||
| * Copyright 2024(c) Analog Devices, Inc. |
| #define ADMFM2000_MIN_GAIN_RAW 0 | ||
| #define ADMFM2000_DEFAULT_GAIN -0x20 | ||
| #define ADMFM2000_NUM_CHANNELS 2 | ||
|
|
| #include "no_os_print_log.h" | ||
|
|
||
|
|
||
| int32_t admfm2000_get_gain(struct admfm2000_dev *dev, uint8_t chan, |
There was a problem hiding this comment.
all these functions should return int
|
|
||
|
|
||
| int32_t admfm2000_get_gain(struct admfm2000_dev *dev, uint8_t chan, | ||
| int32_t *gain) |
There was a problem hiding this comment.
what do you store in the gain variable? doesn't seem to be a gain, rather a raw value after reading gpios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ADMFM2000 is a dual-channel microwave downconverter, with input RF and local oscillator (LO) frequency ranges covering 5 GHz to 32 GHz, with an output intermediate frequency (IF) frequency range from 0.5 GHz to 8 GHz. Added driver and iio_support.
Pull Request Description
Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.
PR Type
PR Checklist