Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct ssl mode in postgres URI #397

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

daxmc99
Copy link
Contributor

@daxmc99 daxmc99 commented Aug 16, 2024

@gnyahay could you take a look at this?

This should be sslMode not ssl
https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLMODE

Signed-off-by: Dax McDonald <31839142+daxmc99@users.noreply.github.com>
@daxmc99 daxmc99 requested a review from a team as a code owner August 16, 2024 00:59
@daxmc99
Copy link
Contributor Author

daxmc99 commented Aug 23, 2024

@gnyahay Happy to clean this up if you let me know that this project is accepting external contributions!

@Btodhunter
Copy link
Member

@daxmc99 Great fix. Thanks for the contribution! Let me know if you need assistance getting it to pass CI.

Signed-off-by: Dax McDonald <31839142+daxmc99@users.noreply.github.com>
@daxmc99
Copy link
Contributor Author

daxmc99 commented Aug 23, 2024

@Btodhunter I think the only issue was not bumping the chart version. Just bumped that

Copy link
Member

@Btodhunter Btodhunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Btodhunter Btodhunter merged commit abca795 into anchore:main Aug 28, 2024
14 of 23 checks passed
@daxmc99 daxmc99 deleted the fix_postgres_uri branch August 29, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants