-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support use of Maven to resolve all dependencies. #2669
Open
GijsCalis
wants to merge
5
commits into
anchore:main
Choose a base branch
from
GijsCalis:use-maven-generate-effective-pom
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support use of Maven to resolve all dependencies. #2669
GijsCalis
wants to merge
5
commits into
anchore:main
from
GijsCalis:use-maven-generate-effective-pom
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GijsCalis
force-pushed
the
use-maven-generate-effective-pom
branch
2 times, most recently
from
February 24, 2024 16:57
fe4e17d
to
6880a0e
Compare
Signed-off-by: Gijs Calis <gijs.calis@triopsys.nl> Signed-off-by: Gijs Calis <51088038+GijsCalis@users.noreply.github.com>
GijsCalis
force-pushed
the
use-maven-generate-effective-pom
branch
from
February 24, 2024 17:00
6880a0e
to
ab5525f
Compare
BTW, this is my first attempt at programming in Go. So I'm certainly open to (and prepared for :-) feedback. |
Note to reviewers: This looks like a special case of #1562, and we should consider the configuration and user experience Syft would need if there were multiple such implementations, e.g. is there a single switch to turn on and off external tooling? |
Signed-off-by: Gijs Calis <51088038+GijsCalis@users.noreply.github.com>
Signed-off-by: Gijs Calis <51088038+GijsCalis@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2017, fixes #1129, fixes #1813
A side note: I've also got a pretty good idea on how to fix many of the issues above without running Maven. But this takes some more time because parent poms and BOMs will need to be traversed. It is unlikely to be completely fail-safe, but should improve the cataloging greatly and fix/improve many outstanding issues.