Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Commit

Permalink
chore: refresh Detekt baseline
Browse files Browse the repository at this point in the history
  • Loading branch information
msfjarvis committed Dec 19, 2022
1 parent 10aa8ed commit 247670e
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 3 deletions.
1 change: 0 additions & 1 deletion detekt-baselines/app.xml
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,5 @@
<ID>UseCheckOrError:SshKey.kt$SshKey$throw IllegalStateException("SSH key does not exist in Keystore")</ID>
<ID>UseCheckOrError:SshKeyGenActivity.kt$SshKeyGenActivity$throw IllegalStateException("Impossible key type selection")</ID>
<ID>UtilityClassWithPublicConstructor:AutofillMatcher.kt$AutofillMatcher</ID>
<ID>WildcardImport:Application.kt$import androidx.appcompat.app.AppCompatDelegate.*</ID>
</CurrentIssues>
</SmellBaseline>
7 changes: 7 additions & 0 deletions detekt-baselines/crypto-common.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<?xml version="1.0" ?>
<SmellBaseline>
<ManuallySuppressedIssues></ManuallySuppressedIssues>
<CurrentIssues>
<ID>LongParameterList:CryptoHandler.kt$CryptoHandler$( keys: List&lt;Key&gt;, passphrase: String, ciphertextStream: InputStream, outputStream: OutputStream, options: DecryptOpts, onDecryptSessionKey: (EncryptedSessionKey) -&gt; DecryptedSessionKey, )</ID>
</CurrentIssues>
</SmellBaseline>
6 changes: 4 additions & 2 deletions detekt-baselines/crypto-pgpainless.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
<?xml version='1.0' encoding='UTF-8'?>
<?xml version="1.0" ?>
<SmellBaseline>
<ManuallySuppressedIssues/>
<ManuallySuppressedIssues></ManuallySuppressedIssues>
<CurrentIssues>
<ID>ForbiddenComment:CachingPublicKeyDataDecryptorFactory.kt$CachingPublicKeyDataDecryptorFactory$* Implementation of the [PublicKeyDataDecryptorFactory] which caches decrypted session keys. That * way, if a message needs to be decrypted multiple times, expensive private key operations can be * omitted. * * This implementation changes the behavior or [.recoverSessionData] to first return any cache hits. * If no hit is found, the method call is delegated to the underlying * [PublicKeyDataDecryptorFactory]. The result of that is then placed in the cache and returned. * * TODO: Do we also cache invalid session keys?</ID>
<ID>ForbiddenComment:PGPKeyManager.kt$PGPKeyManager$// TODO: This is a temp hack for now and in future it should check that the GPGKeyManager can</ID>
<ID>MatchingDeclarationName:PGPSessionKey.kt$PGPEncryptedSessionKey</ID>
</CurrentIssues>
</SmellBaseline>

0 comments on commit 247670e

Please sign in to comment.