Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing check for undefined cache #89

Merged
merged 2 commits into from
Mar 28, 2024
Merged

fix: Add missing check for undefined cache #89

merged 2 commits into from
Mar 28, 2024

Conversation

tchx84
Copy link
Contributor

@tchx84 tchx84 commented Mar 28, 2024

No description provided.

@tchx84
Copy link
Contributor Author

tchx84 commented Mar 28, 2024

@andyholmes while trying flatter with Flatseal got this the following error (see tchx84/Flatseal#673)

Testing "com.github.tchx84.Flatseal.json": Cannot read properties of undefined (reading 'localeCompare')

Checking the code, this is the only thing that made sense...

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 28, 2024
View reviewed changes
src/flatter.js Dismissed Show dismissed Hide dismissed
@tchx84 tchx84 force-pushed the fix-undefined-cache branch from 5ab0945 to ba9b049 Compare March 28, 2024 21:06
@andyholmes andyholmes merged commit 73414ce into andyholmes:main Mar 28, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tchx84 @andyholmes