-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few changes to the original code #23
base: master
Are you sure you want to change the base?
Conversation
Authenticate with password
Sorry for the late reply, I appreciate the changes! I'm a bit hesitant on the password authentication due to some unhandled edge cases (e.g. what if the user has 2FA enabled?). Maybe we could keep both the user/pass and session token auth mechanisms instead of replacing it. As for the Makefile, I would like to keep this script platform-independent so I don't want to merge in a Unix-specific script. At some point a setup.py / pyproject.toml may be appropriate. The other contributions are great but they probably need to be split off as separate PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repo is a lifesaver. Good point on allowing 2 separate modes Andy.
@andyjsmith thanks for the comments! I have updated the PR with following changes (updated the PR description as well)
|
First of all, thanks for this great script. It helped me download all the albums for my kid 😆
Made a few changes to the original code:
-p PASSWORD
option), however if session ID is provided, password will be ignored.--folder
to download all the albums under the specific folderSmugMugDownloader
logging
@retry
to manage retry forget_json()
UseMakefile
to setup a virtual environment to work with