Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add build.rs for additional build-time checks of layout #27

Merged

Conversation

nerodono
Copy link
Contributor

Since the library is relying on UCG layout specification, which information is subject to change, it is useful to check whether these guarantees upheld by the compiler while building. This works, since build.rs would be executed every time smallbox is rebuilt, and rebuilds will happen whenever user changes compiler version.

@nerodono nerodono force-pushed the feat/build-time-test-for-layouts branch from 4dcc205 to 1d9d259 Compare August 22, 2024 15:46
@andylokandy
Copy link
Owner

Thank you!

@nerodono
Copy link
Contributor Author

Hmm, looks like miri don't like stack pointer accesses. I've tried to provide provenance for it, no success

@andylokandy
Copy link
Owner

It's alright, detailed discussion can be found in #21. I may remove the miri test later.

@andylokandy andylokandy merged commit 71daf74 into andylokandy:master Aug 23, 2024
8 of 9 checks passed
@andylokandy
Copy link
Owner

#22 is also related to this pr, because it relies on a stable layout of point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants