Multiple asset fixes for Vite and the application builder in watch mode #29274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
alan-agius4
force-pushed
the
assets-watch-removal
branch
from
5b4a5ef to
6239f22
Compare
alan-agius4
force-pushed
the
assets-watch-removal
branch
4 times, most recently
from
3cd0ae9 to
3791541
Compare
alan-agius4
force-pushed
the
assets-watch-removal
branch
from
3791541 to
ebc3cc8
Compare
alan-agius4
force-pushed
the
assets-watch-removal
branch
2 times, most recently
from
65894c4 to
17e2a53
Compare
alan-agius4
added
target: rc
clydin
approved these changes
Jan 10, 2025
This commit ensures that assets deleted from the source are also removed from the output directory while in watch mode. Previously, deleted assets could persist in the output folder, potentially causing inconsistencies or outdated files to be served. This fix improves the accuracy of the build output by maintaining synchronization between the source and the output directory during development.
…e dev server Ensures the Vite-based development server automatically reloads the browser when asset files are modified. Closes angular#26141
alan-agius4
force-pushed
the
assets-watch-removal
branch
from
17e2a53 to
925e22b
Compare
alan-agius4
added
action: merge
|
The changes were merged into the following branches: main, 19.1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(@angular/build): trigger browser reload on asset changes with Vite dev server
Ensures the Vite-based development server automatically reloads the browser when asset files are modified.
Closes #26141
fix(@angular/build): remove deleted assets from output during watch mode
This commit ensures that assets deleted from the source are also removed from the output directory while in watch mode. Previously, deleted assets could persist in the output folder, potentially causing inconsistencies or outdated files to be served. This fix improves the accuracy of the build output by maintaining synchronization between the source and the output directory during development.