-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@angular/build): update vite to version 6.0.11 #29471
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
force-pushed
the
vite-allowed-hosts-19.1.x
branch
from
January 24, 2025 09:44
42180fa
to
c130c77
Compare
clydin
added
the
action: review
The PR is still awaiting reviews from at least one requested reviewer
label
Jan 24, 2025
alan-agius4
reviewed
Jan 24, 2025
alan-agius4
reviewed
Jan 24, 2025
packages/angular/build/src/builders/dev-server/tests/execute-fetch.ts
Outdated
Show resolved
Hide resolved
alan-agius4
reviewed
Jan 24, 2025
packages/angular/build/src/builders/dev-server/tests/execute-fetch.ts
Outdated
Show resolved
Hide resolved
alan-agius4
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple of nits.
Version update from 6.0.7 to address advisory GHSA-vg6x-rcgg-rjx6 Vite version 6.0.9+, which is now used by the Angular CLI with the `application`/`browser-esbuild` builders, contains a potentially breaking change for some development setups. Examples of such setups include those that use reverse proxies or custom host names during development. The change within a patch release was made by Vite to address a security vulnerability. For projects that directly access the development server via `localhost`, no changes should be needed. However, some development setups may now need to adjust the `allowedHosts` development server option. This option can include an array of host names that are allowed to communicate with the development server. The option sets the corresponding Vite option within the Angular CLI. For more information on the option and its specific behavior, please see the Vite documentation located here: https://vite.dev/config/server-options.html#server-allowedhosts The following is an example of the configuration option allowing `example.com`: ``` "serve": { "builder": "@angular-devkit/build-angular:dev-server", "options": { "allowedHosts": ["example.com"] }, ```
clydin
force-pushed
the
vite-allowed-hosts-19.1.x
branch
from
January 24, 2025 14:31
c130c77
to
f500423
Compare
clydin
added
action: merge
The PR is ready for merge by the caretaker
and removed
action: review
The PR is still awaiting reviews from at least one requested reviewer
labels
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
action: merge
The PR is ready for merge by the caretaker
area: @angular/build
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version update from 6.0.7 to address advisory GHSA-vg6x-rcgg-rjx6
Vite version 6.0.9+, which is now used by the Angular CLI with the
application
/browser-esbuild
builders, contains a potentially breaking change for some development setups. Examples of such setups include those that use reverse proxies or custom host names during development. The change within a patch release was made by Vite to address a security vulnerability. For projects that directly access the development server vialocalhost
, no changes should be needed. However, some development setups may now need to adjust theallowedHosts
development server option. This option can include an array of host names that are allowed to communicate with the development server. The option sets the corresponding Vite option within the Angular CLI. For more information on the option and its specific behavior, please see the Vite documentation located here:https://vite.dev/config/server-options.html#server-allowedhosts
The following is an example of the configuration option allowing
example.com
: