Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

allow to pass attributes from parent component via ngOutlet directive #406

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow to pass attributes from parent component via ngOutlet directive #406

wants to merge 1 commit into from

Conversation

caricsvk
Copy link

ngOutlet is missing implementation for passing attributes to child component. The solution bellow might not be sufficient so I suggest to look at it and rewrite it. The 'if' condition might be problematic. I left a TODO comment there.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@caricsvk
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants