[HiDive] Remove unreleased episodes from list #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing a range download/single selection of an anime that's currently airing episodes that haven't released will still get downloaded at 0 bytes. This will skip them if they have a date range in them, rather than an appropriate title.
|
I apologize for taking so long for getting to review this, I was quite busy on another one of my projects, the change LGTM and appears to work. I am curious on your thoughts though, should it still list it in the output, and just ignore those episodes if requested instead (could be done by just not pushing those episodes to the array)? Incase anybody wants to know when the next episodes come out |
Account for when the episode title is added, but still not released, when it's not available there's a 10 second clip.
Allow listing to be visible but now allow it in the episodes list if it's not available
|
Yea i think that'll work |
|
I could be crazy, but I think that this has broken downloading on hidive now. Season ID 22309, can't seem to download from it. No episodes end up getting pushed to the array I think |
|
im not having this issue: |
|
Okay i saw my own mistake, try now. |
|
Yup, that fixed it. I think it's good to merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing a range download/single selection of an anime that's currently airing episodes that haven't released will still get downloaded at 0 bytes. This will skip them if they have a date range in them, rather than an appropriate title.