refactor: 봉사자의 후원금 결제 확인을 위한 PG API 호출을 트랜잭션에서 분리한다. #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushedrumex
requested review from
funnysunny08,
bjo6300 and
hseong3243
as code owners
|
bjo6300
approved these changes
Jan 28, 2024
hseong3243
approved these changes
Jan 28, 2024
src/main/java/com/clova/anifriends/domain/payment/repository/PaymentRepository.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛏ 작업 사항
📝 작업 요약
기존 방식은 다음과 같은 로직이 하나의 트랜잭션에서 진행되었습니다.
Payment를 조회해서 결제 상태와 결제 금액을 확인paymentSuccess메소드의Transactional애노테이션을 제거하여 각각의 분리된 트랜잭션에서 진행하도록 수정하였고, PG API 와 통신하는 로직을 트랜잭션 외부에서 동작하도록 수정하였습니다.💡 관련 이슈