Revert "feat: add controllable state functionality to combobox items"

This reverts commit b30921a.
animareflection · Feb 1, 2024 · 52f0156 · 52f0156
1 parent 2f6037e
commit 52f0156
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 44 deletions.
diff --git a/src/components/core/Combobox/Combobox.stories.tsx b/src/components/core/Combobox/Combobox.stories.tsx
@@ -1,5 +1,3 @@
-import { useState } from "react";
-
 import { comboboxState } from "./Combobox.spec";
 import { Combobox, Image } from "components/core";
 
@@ -64,31 +62,6 @@ export const Default: Story = {
   },
 };
 
-export const ControlledItems: Story = {
-  args: {
-    size: "md",
-    label: {
-      singular: "Fruit",
-      plural: "Fruit",
-      display: true,
-    },
-    groups: [groups[0]],
-  },
-  render: (args) => {
-    const allItems = args.groups.flatMap((group) => group.items);
-    // eslint-disable-next-line react-hooks/rules-of-hooks
-    const [controlledItems, setControlledItems] = useState(allItems);
-
-    return (
-      <Combobox
-        {...args}
-        controlledItems={controlledItems}
-        setControlledItems={setControlledItems}
-      />
-    );
-  },
-};
-
 export const ImageIcons: Story = {
   args: {
     ...Default.args,

diff --git a/src/components/core/Combobox/Combobox.tsx b/src/components/core/Combobox/Combobox.tsx
@@ -60,11 +60,9 @@ export interface Props
     props?: PrimitiveComboboxLabelProps;
     display?: boolean;
   };
-  groups: Group[];
   /** Custom content render override. */
   content?: ReactNode;
-  controlledItems?: Item[];
-  setControlledItems?: (items: Item[]) => void;
+  groups: Group[];
   itemIndicator?: boolean;
   triggerEnabled?: boolean;
   inputProps?: Omit<InputProps, "size">;
@@ -81,8 +79,6 @@ const Combobox = ({
   itemIndicator = false,
   triggerEnabled = true,
   inputProps,
-  controlledItems,
-  setControlledItems,
   contentProps,
   controlProps,
   positionerProps,
@@ -111,15 +107,13 @@ const Combobox = ({
         item.value.toLowerCase().includes(evt.value.toLowerCase()),
     );
 
-    controlledItems
-      ? setControlledItems?.(filtered.length ? filtered : allItems)
-      : setFilteredItems(filtered.length ? filtered : allItems);
+    setFilteredItems(filtered.length ? filtered : allItems);
   };
 
   return (
     <PrimitiveCombobox
       onInputValueChange={handleChange}
-      items={controlledItems ? controlledItems : filteredItems}
+      items={filteredItems}
       size={size}
       {...rest}
     >
@@ -164,11 +158,7 @@ const Combobox = ({
           {content ||
             groups.map(
               (group) =>
-                group.items.some((item) =>
-                  controlledItems
-                    ? controlledItems.includes(item)
-                    : filteredItems.includes(item),
-                ) && (
+                group.items.some((item) => filteredItems.includes(item)) && (
                   <PrimitiveComboboxItemGroup
                     key={group.label.id}
                     id={group.label.id}
@@ -185,9 +175,7 @@ const Combobox = ({
 
                     {group.items.map(
                       (item) =>
-                        (controlledItems
-                          ? controlledItems.includes(item)
-                          : filteredItems.includes(item)) && (
+                        filteredItems.includes(item) && (
                           <PrimitiveComboboxItem
                             key={item.value}
                             item={item}