Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traditional Chinese (Taiwan) translation #667

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

KnowScratcher
Copy link

I've finished translating traditional chinese, please review my PR. Thanks.

@aplaice
Copy link
Collaborator

aplaice commented Jan 23, 2025

Hi,

Thanks very much for the PR and for your work! It'll be exciting to have this translation!

I have a couple of questions/comments, mainly regarding the structure. Since some of these might have been non-trivial to fix (our CSV structure is in many ways annoying and fiddly!), I've opened a PR to your PR to fix the minor structural issues. I hope this is OK!

  1. src/data/capital.csv

There's an unnecessary first numbered column. (Fixed in PR.)

  1. src/data/country.csv

Why is the latin-alphabet version of the country name the German name of the country? (I'm not sure if we need a latin-alphabet-version of the country name, but having the German one seems very weird.) (Fix not applied.)

(BTW thanks for including the changes from the recent Danish patch!)

  1. src/data/capital_info.csv

(For consistency with all the other translations) I think that all the capital infos should end with a full stop (or the appropriate equivalent), unless this is not conventional in Taiwanese Chinese. (Fix not applied.)

  1. src/data/country_info.csv

a) The order of the rows has changed, which isn't an issue in itself, but makes reviewing harder. (Fixed in PR.)

b) Similarly to 3, the country infos should (probably) all end in full stops. (Fix not applied.)

  1. src/data/flag_similarity.csv

The order of the rows has changed, which isn't an issue in itself, but makes reviewing harder. (Fixed in PR.)

(Note that the capital hints and flag similarities should not end in full stops, for consistency with the other translations. (This is already the case — nothing needs to change.))

  1. src/data/guid.csv

The new GUIDs haven't been generated. (Fixed in PR.)


In the PR I've also added a BrainBrew recipe for generating the CrowdAnki deck.

I haven't at all looked at the actual translation, so I have no idea whether there are any minor typos etc., but hopefully future users will catch any (if there are any!).


There's also an organisation question of how we want to call the output deck. For now, I've settled on Ultimate Geography [ZH-TW], but this can be changed if anybody has preferences.

The current Chinese translation (simplified characters) has been kept as just zh; I have no opinion on whether we should change the code (to zh-cn?) or not.

Thanks again for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants