Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash for unsupported dimension events #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michnovka
Copy link

Fixes #143

@nachogarcia
Copy link

This fixes a lot of the problems that this integrations has.
It might be nice to log the error, not just pass the catch block.

@anotherjulien Are you still maintaining the project?

@dan-it
Copy link

dan-it commented Dec 10, 2024

Hello @michnovka! I'm having a similar problem that I think this fix doesn't address (or at least I was unable to install it)

Setup:

  1. I didn't configure all my lights in myhome.yaml (I'm using the extension mostly to control my climate)
  2. I have some dimmable lights that are not configured.

What happens:
Whenever I see on the bus a message like *1*7*0504## (light at 70%) the messages stop updating.

I solved by simply configuring the lights with "dimmable: true" but I think this behaviour may be related to what you fix here.

Great work anyways!

@michnovka
Copy link
Author

@dan-it Yes, I think this is related. What do you mean you were unable to install it?

@dan-it
Copy link

dan-it commented Dec 10, 2024

I am new to HA so I'm not sure that replacing the contents of homeassistant/custom_components/myhome/light.py and restarting HA is enough. That's what I did and it still has the same issue.

@wave68runner
Copy link

Hi. If I would like to use this refork whats the best way to proceed. I don’t a a copy link to paste the repository into hacs. So I have to copy the differents files and paste them into HA?
I tried yesterday the repository of Smf666 but have the same issues. And when I try to download the repository of Michnovka HA that it can’t download all the files.
thanks for your feedback

@HA-n00b-alt
Copy link

Hi. If I would like to use this refork whats the best way to proceed. I don’t a a copy link to paste the repository into hacs. So I have to copy the differents files and paste them into HA? I tried yesterday the repository of Smf666 but have the same issues. And when I try to download the repository of Michnovka HA that it can’t download all the files. thanks for your feedback

Open an issue on the fork repo. It's only a matter of uploading the distribution file, maybe Michnovka will do it. In alternative yes you can just overwrite the files but beware you also need to do it with the OWNd library as some fixes are needed there.

@wave68runner
Copy link

Ownd library ?? I saw that on the anotherjulien page. But I havenever installed that. And see no files with that name in my HA config….
Do I need to install that custom repo ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certain messages cause error stopping incoming event loop from reading new messages
5 participants