Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate changelog default value #152

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Apr 17, 2024

Fixing minor bug introduced by #151

The default value for the custom_paths has been set to "" this means when the workflow is called without overriding this the action is trying to run the command validate_changelog.py --ref main --custom-paths which produces the following error validate_changelog.py: error: argument --custom-paths: expected one argument

This has been tested here https://github.com/abikouo/gha_testing/actions/runs/8726044441/job/23940402498?pr=133

@abikouo abikouo force-pushed the test_default_value branch 2 times, most recently from 8fb3dea to 17b10f4 Compare April 17, 2024 17:06
@abikouo abikouo force-pushed the test_default_value branch from 17b10f4 to 6e61b36 Compare April 17, 2024 17:14
@gravesm
Copy link
Contributor

gravesm commented Apr 17, 2024

What's the bug that this is fixing?

@abikouo
Copy link
Contributor Author

abikouo commented Apr 18, 2024

What's the bug that this is fixing?

The PR description has been updated

@abikouo abikouo merged commit dc67cf6 into ansible-network:main Apr 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants