Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Depends-On #55

Merged
merged 7 commits into from
Apr 5, 2023
Merged

Support Depends-On #55

merged 7 commits into from
Apr 5, 2023

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Mar 24, 2023

This github action allows to override the version of a collection to checkout based on keyword depends-on from pull request title
Extracted from #45

@abikouo
Copy link
Contributor Author

abikouo commented Mar 24, 2023

@Qalthos this one the feature extracted from #45
closes #49

.pre-commit-config.yaml Show resolved Hide resolved
.github/actions/checkout_repository/resolve_dependency.py Outdated Show resolved Hide resolved
.github/actions/checkout_repository/resolve_dependency.py Outdated Show resolved Hide resolved
.github/actions/checkout_repository/action.yml Outdated Show resolved Hide resolved
@abikouo abikouo requested a review from Qalthos March 28, 2023 08:47
@Qalthos Qalthos force-pushed the depends_on branch 2 times, most recently from 8a31c25 to 175c695 Compare March 29, 2023 14:39
Copy link
Contributor

@Qalthos Qalthos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, can you replace the checkout step

.github/actions/checkout_repository/action.yml Outdated Show resolved Hide resolved
@Qalthos
Copy link
Contributor

Qalthos commented Mar 29, 2023

Not with my fork, obviously, but can you update the existing workflows to switch to this instead of checkout? changelog and safe-to-test shouldn't need to be updated, but the rest would benefit from having it.

cf. Qalthos@8a31c25

@abikouo
Copy link
Contributor Author

abikouo commented Mar 30, 2023

Not with my fork, obviously, but can you update the existing workflows to switch to this instead of checkout? changelog and safe-to-test shouldn't need to be updated, but the rest would benefit from having it.

cf. Qalthos@8a31c25

The only workflow which can benefit from this action is integration.yml, this action is used to checkout dependency only (It has been updated accordingly), this is why the repository parameter is required, we don't want to add depends-on in a repository being checkout

@abikouo abikouo requested a review from Qalthos March 30, 2023 10:30
@Qalthos
Copy link
Contributor

Qalthos commented Mar 31, 2023

The only workflow which can benefit from this action is integration.yml, this action is used to checkout dependency only (It has been updated accordingly), this is why the repository parameter is required, we don't want to add depends-on in a repository being checkout

But this can absolutely be used to depends-on a PR that fixes sanity tests, for example. It's a contrived situation, but https://github.com/ansible-collections/ansible.utils/pull/248/checks?check_run_id=12373927044 and https://github.com/ansible-collections/ansible.utils/pull/248/checks are runs of the same checks with and without depends-on where another PR is fixing the underlying issue.

setup.cfg Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@abikouo
Copy link
Contributor Author

abikouo commented Apr 3, 2023

The only workflow which can benefit from this action is integration.yml, this action is used to checkout dependency only (It has been updated accordingly), this is why the repository parameter is required, we don't want to add depends-on in a repository being checkout

But this can absolutely be used to depends-on a PR that fixes sanity tests, for example. It's a contrived situation, but https://github.com/ansible-collections/ansible.utils/pull/248/checks?check_run_id=12373927044 and https://github.com/ansible-collections/ansible.utils/pull/248/checks are runs of the same checks with and without depends-on where another PR is fixing the underlying issue.

all workflows have been updated with checkout_repository

@abikouo abikouo requested a review from Qalthos April 3, 2023 13:10
@Qalthos Qalthos merged commit ab20476 into ansible-network:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants