Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unable to update the port data when it is already in use #40

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ilyaliao
Copy link

@ilyaliao ilyaliao commented Jul 15, 2024

Description

This PR fixes the issue where data was not correctly updated when port 4000 was in use.

I noticed that listening to http.createServer() does not adequately detect if a port is already in use.

As seen in the screenshot, port 4000 is in use, but both npx vite and the notification still show port 4000.

截圖 2024-07-15 下午3 51 33

I resolved this by installing portfinder to check for port occupancy and obtain a new port if necessary.


When port 4000 is in use.

截圖 2024-07-15 下午3 41 41

When port 4001 is in use.

截圖 2024-07-15 下午3 42 16

@antfu
Copy link
Owner

antfu commented Jul 15, 2024

Could we use https://www.npmjs.com/package/get-port-please ? It would align more with our ecosystem and has zero-deps. Thank you

@ilyaliao
Copy link
Author

ilyaliao commented Jul 15, 2024

I update it 😀

I noticed the portfinder will automatically select the host based on ipv4 or ipv6, but get-port-please seems not ...?

If the host is not ::1, get-port-please can not correct work (always return 4000).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants