Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the WithContext option #143

Merged
merged 1 commit into from
Jan 9, 2024
Merged

add the WithContext option #143

merged 1 commit into from
Jan 9, 2024

Conversation

anthdm
Copy link
Owner

@anthdm anthdm commented Jan 9, 2024

Users are now able to pass a context.Context. This is super handy when spawning goroutines from actors that need values passed down or cancelation

@anthdm anthdm requested a review from perbu January 9, 2024 19:01
Copy link
Collaborator

@perbu perbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea. What happens when the context is cancelled? Perhaps that should be the subject of a test?

Fine to merge, however.

@anthdm anthdm merged commit 3750730 into master Jan 9, 2024
2 checks passed
@anthdm anthdm deleted the context branch January 9, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants