Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The new Feature Gate Core BPF program is live at
Feature111111...
on both testnet and devnet, and will soon be on mainnet-beta.With this new program, we can revoke features that are pending activation. The program has only one instruction,
RevokePendingActivation
, which simply "closes" a newly created feature account by:However, core contributors who wish to use this new capability have no way of doing so from the CLI.
Summary of Changes
Add a new command to the
solana feature
CLI that invokes theRevokePendingActivation
instruction on the Feature Gate program to revoke a pending activation.For more information about this instruction, see the program's instruction source. However, in summary, once a feature is activated with
solana feature activate
, it can be revoked at any time before the epoch rollover, while the state is still zeroed. Once the epoch concludes and the feature is activated by the runtime, the account is bestowed with validFeature
state and thus can no longer be revoked.