Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sets accounts-db test to use mmap storage access explicitly #4369

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Sets accounts-db test to use mmap storage access explicitly #4369

merged 1 commit into from
Jan 9, 2025

Conversation

brooksprumo
Copy link

Problem

When setting File Io to be the default storage access method in #4365, a test was failing because it required Mmaps.

Summary of Changes

Update the test to explicitly use Mmap.

@brooksprumo brooksprumo self-assigned this Jan 9, 2025
@brooksprumo brooksprumo marked this pull request as ready for review January 9, 2025 22:04
jeffwashington
jeffwashington approved these changes Jan 9, 2025
View reviewed changes
Copy link

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo merged commit 639006d into anza-xyz:master Jan 9, 2025
40 checks passed
@brooksprumo brooksprumo deleted the file-io/fix-test branch January 9, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffwashington jeffwashington jeffwashington approved these changes

@HaoranYi HaoranYi HaoranYi approved these changes

Assignees

@brooksprumo brooksprumo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brooksprumo @HaoranYi @jeffwashington