Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.1: quic: disable send fairness (backport of #4586) #4590

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 23, 2025

Problem

quinn-rs/quinn#2002 was implemented in Quinn but never activated in Agave.

Summary of Changes

Disable send fairness in Quic (transport config).


This is an automatic backport of pull request #4586 done by Mergify.

(cherry picked from commit 1e721f0)

# Conflicts:
#	quic-client/src/nonblocking/quic_client.rs
#	streamer/src/nonblocking/testing_utilities.rs
#	tpu-client-next/src/quic_networking.rs
@mergify mergify bot added the conflicts label Jan 23, 2025
@mergify mergify bot requested a review from a team as a code owner January 23, 2025 02:21
Copy link
Author

mergify bot commented Jan 23, 2025

Cherry-pick of 1e721f0 has failed:

On branch mergify/bp/v2.1/pr-4586
Your branch is up to date with 'origin/v2.1'.

You are currently cherry-picking commit 1e721f086.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   sdk/src/quic.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   quic-client/src/nonblocking/quic_client.rs
	both modified:   streamer/src/nonblocking/testing_utilities.rs
	both modified:   tpu-client-next/src/quic_networking.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@alessandrod alessandrod merged commit 593773d into v2.1 Jan 23, 2025
29 checks passed
@alessandrod alessandrod deleted the mergify/bp/v2.1/pr-4586 branch January 23, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants