docs: add troubleshooting option for openid-connect #11892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solved my issue when nothing else did. Signed-off-by: Yarden Shoham <git@yardenshoham.com>
dosubot
bot
added
size:S
yardenshoham
changed the title
kayx23
reviewed
Jan 7, 2025
| bearer_only: false | ||
| # this comes from https://github.com/zmartzone/lua-resty-openidc, if this is missing, all information will be stored in the session. This | ||
| # causes the cookies to be too large and the request to fail. We have control over id_token, user, enc_id_token, and access_token. | ||
| # We currently include only access_token in the session. If this gets too big we can remove it as well. |
There was a problem hiding this comment.
Could you simplify the comment to
# use session_contents option to configure which information among id_token, user, enc_id_token, and access_token, get stored.
and add the same doc update to the Chinese doc?
kayx23
reviewed
Jan 7, 2025
| # causes the cookies to be too large and the request to fail. We have control over id_token, user, enc_id_token, and access_token. | ||
| # We currently include only access_token in the session. If this gets too big we can remove it as well. | ||
| session_contents: | ||
| access_token: true |
There was a problem hiding this comment.
Technically this is an attribute that was previously not explicitly exposed, so should be also be added to attribute section of the doc; as well as to the plugin schema in the source code (relevant tests need to be updated as well) 💭 cc: @juzhiyuan
5 tasks
|
Maybe you could take over and do everything in #11889 |
|
Ok I will evaluate and update accordingly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solved my issue when nothing else did.
References #11711