Skip to content

Commit

Permalink
[CALCITE-4459] Type annotations defeat org.jboss:jandex bytecode pars…
Browse files Browse the repository at this point in the history
…er sometimes
  • Loading branch information
vlsi committed Jan 16, 2021
1 parent 67ece68 commit 8899380
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 2 deletions.
1 change: 1 addition & 0 deletions bom/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ dependencies {
apiv("org.hamcrest:hamcrest-library", "hamcrest")
apiv("org.hsqldb:hsqldb")
apiv("org.incava:java-diff")
apiv("org.jboss:jandex")
apiv("org.jsoup:jsoup")
apiv("org.junit.jupiter:junit-jupiter-api", "junit5")
apiv("org.junit.jupiter:junit-jupiter-params", "junit5")
Expand Down
11 changes: 11 additions & 0 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ plugins {
id("com.github.spotbugs")
id("de.thetaphi.forbiddenapis") apply false
id("net.ltgt.errorprone") apply false
id("com.github.vlsi.jandex") apply false
id("org.owasp.dependencycheck")
id("com.github.johnrengelman.shadow") apply false
// IDE configuration
Expand All @@ -68,6 +69,7 @@ val lastEditYear by extra(lastEditYear())
val enableSpotBugs = props.bool("spotbugs")
val enableCheckerframework by props()
val enableErrorprone by props()
val skipJandex by props(false) // It will be enabled by default as Jandex issues are resolved
val skipCheckstyle by props()
val skipAutostyle by props()
val skipJavadoc by props()
Expand Down Expand Up @@ -443,6 +445,15 @@ allprojects {
apply(plugin = "de.thetaphi.forbiddenapis")
apply(plugin = "maven-publish")

if (!skipJandex) {
apply(plugin = "com.github.vlsi.jandex")

project.configure<com.github.vlsi.jandex.JandexExtension> {
toolVersion.set("jandex".v)
skipIndexFileGeneration()
}
}

if (!enableGradleMetadata) {
tasks.withType<GenerateModuleMetadata> {
enabled = false
Expand Down
4 changes: 2 additions & 2 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ org.checkerframework.version=0.5.10
com.github.autostyle.version=3.0
com.github.johnrengelman.shadow.version=5.1.0
com.github.spotbugs.version=2.0.0
com.github.vlsi.vlsi-release-plugins.version=1.70
com.github.vlsi.vlsi-release-plugins.version=1.72
com.google.protobuf.version=0.8.10
de.thetaphi.forbiddenapis.version=3.1
kotlin.version=1.3.50
Expand All @@ -65,6 +65,7 @@ checkerframework.version=3.7.0
checkstyle.version=8.28
spotbugs.version=3.1.11
errorprone.version=2.4.0
jandex.version=2.2.2.Final

# We support Guava versions as old as 14.0.1 (the version used by Hive)
# but prefer more recent versions.
Expand All @@ -84,7 +85,6 @@ commons-lang3.version=3.8
dropwizard-metrics.version=4.0.5
elasticsearch.version=7.0.1
embedded-redis.version=0.6
errorprone.version=2.4.0
esri-geometry-api.version=2.2.0
foodmart-data-hsqldb.version=0.3
foodmart-data-json.version=0.4
Expand Down
7 changes: 7 additions & 0 deletions settings.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ pluginManagement {
idv("com.github.vlsi.crlf", "com.github.vlsi.vlsi-release-plugins")
idv("com.github.vlsi.gradle-extensions", "com.github.vlsi.vlsi-release-plugins")
idv("com.github.vlsi.ide", "com.github.vlsi.vlsi-release-plugins")
idv("com.github.vlsi.jandex", "com.github.vlsi.vlsi-release-plugins")
idv("com.github.vlsi.license-gather", "com.github.vlsi.vlsi-release-plugins")
idv("com.github.vlsi.stage-vote-release", "com.github.vlsi.vlsi-release-plugins")
idv("com.google.protobuf")
Expand All @@ -37,6 +38,12 @@ pluginManagement {
idv("org.owasp.dependencycheck")
kotlin("jvm") version "kotlin".v()
}
if (extra.has("enableMavenLocal") && extra["enableMavenLocal"].toString().ifBlank { "true" }.toBoolean()) {
repositories {
mavenLocal()
gradlePluginPortal()
}
}
}

plugins {
Expand Down

0 comments on commit 8899380

Please sign in to comment.