[CALCITE-4199] review-only: nullability annotations #2273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyafan82
reviewed
Nov 23, 2020
liyafan82
reviewed
Nov 23, 2020
liyafan82
reviewed
Nov 24, 2020
…eName non-nullable
CheckerFramework needs an annotated JDK, so it is not activated by default
Add private class PosBuilder to allow lists or arrays of positions to be summed without creating intermediate collections. Nullness is also more transparent.
…t, i) returns null
vlsi
force-pushed
the
checkerframework_reviewsplit
branch
from
dc6ef83 to
4d21ea7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits #2268 into "Refactor: prepare code for nullability annotations" and "Add @nullable annotations only
dc6ef83" commits.
It might be slightly easier for the review, however, the key commit is still big 2e00e9c