Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CURATOR-721] Upgrade Guava Listenablefuture #509

Merged

Conversation

froque
Copy link
Contributor

@froque froque commented Nov 5, 2024

This removes duplicate class ListenableFuture.
See more at google/guava#7385

This removes duplicate class ListenableFuture.
See more at google/guava#7385
@eolivelli
Copy link
Contributor

Reopening and closing in order to see if CI kicks in

@eolivelli eolivelli closed this Dec 12, 2024
@eolivelli eolivelli reopened this Dec 12, 2024
@tisonkun tisonkun requested review from kezhuw and eolivelli December 21, 2024 07:19
Copy link
Member

@kezhuw kezhuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think we could even drop directy dependencies to com.google.guava:listenablefuture. But it could be a leftover as we probably have more to clean.

@kezhuw kezhuw merged commit 8bbcdbf into apache:master Jan 10, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants