-
Notifications
You must be signed in to change notification settings - Fork 980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRILL-8517: Bump com.google.protobuf:protobuf-java from 3.16.3 to 3.25.5 #2945
DRILL-8517: Bump com.google.protobuf:protobuf-java from 3.16.3 to 3.25.5 #2945
Conversation
Test failures caused by:
|
@dependabot rebase |
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
@cgivre Dependabot says no to rebase, I can rebase and force push. |
Bumps [com.google.protobuf:protobuf-java](https://github.com/protocolbuffers/protobuf) from 3.16.3 to 3.25.5. - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl) - [Commits](protocolbuffers/protobuf@v3.16.3...v3.25.5) --- updated-dependencies: - dependency-name: com.google.protobuf:protobuf-java dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
2ba8a81
to
9da0095
Compare
Looks like we need more changes.
|
Update pom.xml try arduino/setup-protoc Update pom.xml Update ci.yml Update ci.yml revert ci.yml Update ci.yml
72e8b36
to
6026d70
Compare
@@ -120,6 +120,7 @@ | |||
<configuration> | |||
<cleanOutputFolder>false</cleanOutputFolder> | |||
<outputDirectory>${basedir}/src/main/java</outputDirectory> | |||
<ignoreVersions>true</ignoreVersions> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- needed because there is a CI job that uses an older protobuf lib than our protobuf-java lib
- I tried to get the CI job to use a newer protobuf lib but the format of the protobuf zip has changed and I'm not sure how to get the existing build to use a newer protobuf zip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
Bumps com.google.protobuf:protobuf-java from 3.16.3 to 3.25.5.
Release notes
Sourced from com.google.protobuf:protobuf-java's releases.
... (truncated)
Commits
9d0ec0f
Updating version.json and repo version numbers to: 25.54a197e7
Merge pull request #18387 from protocolbuffers/cp-lp-25b5a7cf7
Remove RecursiveGroup test case which doesn't exist in 25.x pre-Editionsf000b7e
Fix merge conflict by adding optional label to proto2 unittest_lite.proto4728531
Add recursion check when parsing unknown fields in Java.850fcce
Internal changeb704498
Internal changee673479
Fix cord handling in DynamicMessage and oneofs. (#18375)8a60b65
Merge pull request #17704 from protocolbuffers/cp-segv94a2663
Fixed a SEGV when deep copying a non-reified sub-message.You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.