Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable testWriteUTF on Windows #15035

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Disable testWriteUTF on Windows #15035

merged 1 commit into from
Jan 5, 2025

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Jan 5, 2025

What is the purpose of the change?

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.75%. Comparing base (713388a) to head (96f4a92).

Additional details and impacted files
@@            Coverage Diff            @@
##                3.3   #15035   +/-   ##
=========================================
  Coverage     60.75%   60.75%           
+ Complexity    10862    10861    -1     
=========================================
  Files          1882     1882           
  Lines         85997    85997           
  Branches      12881    12881           
=========================================
+ Hits          52245    52251    +6     
+ Misses        28307    28298    -9     
- Partials       5445     5448    +3     
Flag Coverage Δ
integration-tests 32.98% <ø> (-0.01%) ⬇️
samples-tests 29.21% <ø> (-0.02%) ⬇️
unit-tests 58.94% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ AlbumenJ merged commit 8e49668 into apache:3.3 Jan 5, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants