Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-28983 Static resources are not loaded on REST web UI pages in dev mode #6582

Open
wants to merge 1 commit into
base: branch-3
Choose a base branch
from

Conversation

PDavid
Copy link
Contributor

@PDavid PDavid commented Jan 7, 2025

This way the hbase-webapps/static source directory (which holds JS, CSS, image files) is not duplicated anymore. It is only present under hbase-server. This directory is then coped by maven-resources-plugin to the target directory of the REST and Thrift projects.

For this deleted the static directory below the Thrift project.

(cherry picked from commit b445217)

@PDavid
Copy link
Contributor Author

PDavid commented Jan 7, 2025

This is the backport of #6491 to branch-3.

@PDavid
Copy link
Contributor Author

PDavid commented Jan 7, 2025

Tested this the same way: #6491 (comment)

@PDavid PDavid marked this pull request as ready for review January 8, 2025 08:03
@NihalJain NihalJain added the backport This PR is a back port of some issue or issues already committed to master label Jan 9, 2025
…ev mode

This way the `hbase-webapps/static` source directory (which holds JS, CSS, image files) is not duplicated anymore. It is only present under `hbase-server`. This directory is then coped by maven-resources-plugin to the target directory of the REST and Thrift projects.

For this deleted the static directory below the Thrift project.

(cherry picked from commit b445217)
@PDavid PDavid force-pushed the HBASE-28983-rest-ui-resources-missing-branch-3 branch from a4e9417 to c8f4bac Compare January 10, 2025 07:09
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 44s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 jshint 0m 0s jshint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-3 Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 4m 22s branch-3 passed
+1 💚 compile 1m 31s branch-3 passed
+1 💚 spotless 0m 53s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 3m 45s the patch passed
+1 💚 compile 1m 59s the patch passed
+1 💚 javac 1m 59s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 xmllint 0m 0s No new issues.
+1 💚 hadoopcheck 13m 49s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚 spotless 0m 45s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 17s The patch does not generate ASF License warnings.
38m 11s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6582/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6582
Optional Tests dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile jshint
uname Linux 706ef8259d70 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-3 / c8f4bac
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 90 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6582/2/console
versions git=2.34.1 maven=3.9.8 xmllint=20913
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 32s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-3 Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 3m 36s branch-3 passed
+1 💚 compile 1m 21s branch-3 passed
+1 💚 javadoc 1m 1s branch-3 passed
+1 💚 shadedjars 7m 34s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 23s Maven dependency ordering for patch
+1 💚 mvninstall 4m 34s the patch passed
+1 💚 compile 1m 32s the patch passed
+1 💚 javac 1m 32s the patch passed
+1 💚 javadoc 1m 4s the patch passed
+1 💚 shadedjars 6m 30s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 6m 50s hbase-thrift in the patch passed.
+1 💚 unit 4m 22s hbase-rest in the patch passed.
40m 54s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6582/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6582
Optional Tests javac javadoc unit shadedjars compile
uname Linux 822ee5ff238b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-3 / c8f4bac
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6582/2/testReport/
Max. process+thread count 1729 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6582/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport This PR is a back port of some issue or issues already committed to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants